Add "enabled" flag for SQS Offline#117
Open
fernyettheplant wants to merge 1 commit intoCoorpAcademy:masterfrom
fernyettheplant:feat/add-enabled-flag
Open
Add "enabled" flag for SQS Offline#117fernyettheplant wants to merge 1 commit intoCoorpAcademy:masterfrom fernyettheplant:feat/add-enabled-flag
fernyettheplant wants to merge 1 commit intoCoorpAcademy:masterfrom
fernyettheplant:feat/add-enabled-flag
Conversation
Member
AdrieanKhisbe
left a comment
AdrieanKhisbe
left a comment
There was a problem hiding this comment.
Looks good to me!
Would be interesting to have it applied to the other offline plugins.
I can take care if you want @jefer590 , along with rebasing to fix conflict, (and maybe little refactor (quick exit if (!enabled) return log();)
Author
|
@AdrieanKhisbe thanks for the review |
|
What ever happened to this? This feature would be extremely useful |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some cases that we wanted to do isolated functional tests but SQS was always required by it. With this flag, you can disable SQS offline if you need to run certain modules of your Serverless offline application in isolation.