Skip to content

Conversation

@gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Feb 2, 2026

Note

Medium Risk
Touches core Tinybird ETL/pipeline SQL and adds new stored columns, so mistakes could skew analytics outputs across buckets and dashboards even though the change is conceptually straightforward.

Overview
Precomputes and persists member geolocation + timezone on all activityRelations_deduplicated_cleaned_bucket_* datasources by adding memberCountryCode and memberTimezoneOffset and populating them during the activityRelations_bucket_clean_enrich_copy_pipe_* copy/enrich step.

Refactors enrichment pipes to join members_sorted and compute org vs member country separately, and updates downstream analytics: contributions_with_local_time.pipe now reads memberTimezoneOffset directly, while contributors_geo_distribution.pipe switches from fuzzy location parsing to grouping by memberCountryCode and mapping via country_mapping.

Written by Cursor Bugbot for commit f86427c. This will update automatically on new commits. Configure here.

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
@gaspergrom gaspergrom self-assigned this Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

FROM activityRelations_deduplicated_cleaned_bucket_union
WHERE
platform IN ('git', 'github', 'gitlab', 'gerrit')
AND memberTimezoneOffset != 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTC timezone contributors incorrectly filtered out

High Severity

The filter memberTimezoneOffset != 0 incorrectly excludes contributions from members in UTC timezone countries (e.g., Iceland, Ghana, Liberia, Burkina Faso, Mali, Senegal, and 9+ more). The old code used WHERE idx != 0 to check if a country match was found (index > 0 means a match), while the new code filters on the actual timezone value. Since the default for unknown locations is offset 0, and valid UTC countries also have offset 0, legitimate contributions from ~15 countries are now silently dropped.

Fix in Cursor Fix in Web

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@gaspergrom gaspergrom closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant