fix: use category name instead of uuid generated by llm (CM-889)#3822
Open
fix: use category name instead of uuid generated by llm (CM-889)#3822
Conversation
services/apps/categorization_worker/src/activities/activities.ts
Outdated
Show resolved
Hide resolved
joanagmaia
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Stricter prompt + double validation for category UUIDs
Summary
This PR hardens LLM category selection by:
What changed
Prompt
Post-processing / Validation
idmatches UUID format and exists incategories(DB list).idfails (missing/invalid/not in DB), try resolving byname(case-insensitive) and use the DBid.idnornameresolves to a DB category, skip the entry and warn.Why
LLM outputs can return:
This ensures output is always DB-consistent, prevents silent data corruption, and keeps categorization within the authoritative category set.
Note
Medium Risk
Moderate risk because it changes production categorization behavior and introduces filtering/correction logic that could drop or alter LLM-selected categories if matching fails.
Overview
Tightens the LLM category-classification flow by switching the category list in the prompt from grouped text to an authoritative closed-set JSON array and adding strict output constraints/self-check instructions to reduce name/id drift.
Adds post-processing in
findCategoriesWithLLMto handlenullLLM responses and to ensure returned category IDs are DB-consistent: accept only IDs that are valid UUIDs and exist in the fetched category list, otherwise resolve by case-insensitive name and replace with the DB UUID, skipping unknown categories with warnings.Written by Cursor Bugbot for commit 0f8d57e. This will update automatically on new commits. Configure here.