Conversation
- Add some CMake options - add min-api as subdirectory - add c74_add_project function that can be used to create a library target with the necessary configuration for a max external
Author
|
I forgot to note: I tried that out with all the default projects and they all work fine. Some have additional CMake code but this is no problem. Of course I didn't want to push these changes until you said you'd want to migrate all projects to this new solution. Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
c74_add_project.cmakefile with commandc74_add_project()to replace includes of the pre and post scripts. The library output directories are set here instead of in themax-pretarget.cmakewhich makes more sense because the path lies in the min-devkit folder, not in the max-sdk-base.min-apias subdirectory to bring all targets and functions into scope.min-apican still be a totally independant repository. The change here is that the optionBUILD_DOCUMENTATIONis available. Suggestion: we could add aif(PROJECT_IS_TOP_LEVEL)in theCMakeLists.txtfile ofmin-apito only supply that option whenmin-apiis built on its own.