Draft
Conversation
Refactor Bitcoin services into shared bitcoin-based abstractions (BitcoinBasedFeeService, BitcoinBasedClient) for UTXO blockchain reuse. Add full Firo support: node client, PayIn (register/send), PayOut (prepare/payout), DEX strategies, deposit addresses, asset seed data, and infrastructure config.
Firo is UTXO-based like Bitcoin and requires forwarding from deposit addresses to the liquidity address before payouts.
- Rewrite send() to use explicit UTXO input via createrawtransaction instead of sendmany (ensures only the specified deposit UTXO is spent) - Rewrite sendMany() with manual coin selection from liquidity address only (listunspent filtered by address) to prevent spending deposit/ payment UTXOs - Extract buildSignAndBroadcast() for shared raw TX building logic - Fix getBalance() to use listunspent on liquidity address instead of getbalance with default account (which returns negative due to Firo's legacy account system) - Remove unused FiroController and clean up FiroModule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan