Upgraded Microsoft.IO.RecyclableMemoryStream -> 3.0.1. Addded NET 8.0…#15
Open
MiguelGuedelha wants to merge 1 commit intoDaniilSokolyuk:masterfrom
Open
Conversation
… targets. Fixed sample project
|
Would love to see this merged and released 👍 |
enkelmedia
reviewed
May 30, 2025
| BlockSize = blockSize, | ||
| LargeBufferMultiple = largeBufferMultiple, | ||
| MaximumBufferSize = maximumBufferSize, | ||
| GenerateCallStacks = true, |
There was a problem hiding this comment.
I played around with my own fork inspired by yours and got an error during hot reload.
Unable to cast object of type 'System.Attribute[]' to type 'System.Runtime.CompilerServices.StateMachineAttribute[]'.'
Turns out it was GenerateCallStacks = true, that did not play nice with hot reload, setting this to false solved the problem for me.
|
Will this ever get merged? 🤔 |
|
Just putting this to whoever stumbles upon this, just fork or make the changes yourself and reference the built project in your webapplication. I can confirm these changes work and is production stable. We have run this already for a couple of months without any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern systems that I'm currently working with, such as Umbraco have dependencies on the new v3 versions of Microsft.IO.RecyclableMemoryStream on their newer versions, this leads to a version conflict that forces me to use the newer v3 versions. These versions have breaking changes on how the Memory Manager is created, fixed in this PR.
Not entirely sure if this is too much change for a single PR + how it should be moved forward since the MS package upgrade is a breaking change.
Most likely would require the update to be part of a 3.0.0 release of this package into nuget if it was to be merged and released?