-
Notifications
You must be signed in to change notification settings - Fork 324
Allow running wallclock profiler even without tracer #10298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082749
Total [baseline] (8.731 s) : 0, 8730513
Agent [candidate] (1.088 s) : 0, 1088468
Total [candidate] (8.801 s) : 0, 8800877
section iast
Agent [baseline] (1.223 s) : 0, 1222803
Total [baseline] (9.302 s) : 0, 9302239
Agent [candidate] (1.229 s) : 0, 1229166
Total [candidate] (9.298 s) : 0, 9298364
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (650.083 ms) : 0, 650083
BytebuddyAgent [candidate] (653.701 ms) : 0, 653701
GlobalTracer [baseline] (282.571 ms) : 0, 282571
GlobalTracer [candidate] (284.679 ms) : 0, 284679
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (32.684 ms) : 0, 32684
Debugger [baseline] (67.487 ms) : 0, 67487
Debugger [candidate] (67.317 ms) : 0, 67317
Remote Config [baseline] (644.58 µs) : 0, 645
Remote Config [candidate] (614.44 µs) : 0, 614
Telemetry [baseline] (8.947 ms) : 0, 8947
Telemetry [candidate] (8.941 ms) : 0, 8941
Flare Poller [baseline] (3.786 ms) : 0, 3786
Flare Poller [candidate] (3.822 ms) : 0, 3822
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (790.746 ms) : 0, 790746
BytebuddyAgent [candidate] (796.241 ms) : 0, 796241
GlobalTracer [baseline] (256.372 ms) : 0, 256372
GlobalTracer [candidate] (257.989 ms) : 0, 257989
IAST [baseline] (26.821 ms) : 0, 26821
IAST [candidate] (27.039 ms) : 0, 27039
AppSec [baseline] (34.636 ms) : 0, 34636
AppSec [candidate] (35.091 ms) : 0, 35091
Debugger [baseline] (64.939 ms) : 0, 64939
Debugger [candidate] (63.643 ms) : 0, 63643
Remote Config [baseline] (599.687 µs) : 0, 600
Remote Config [candidate] (569.142 µs) : 0, 569
Telemetry [baseline] (8.488 ms) : 0, 8488
Telemetry [candidate] (8.392 ms) : 0, 8392
Flare Poller [baseline] (3.661 ms) : 0, 3661
Flare Poller [candidate] (3.553 ms) : 0, 3553
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086213
Total [baseline] (10.768 s) : 0, 10767967
Agent [candidate] (1.097 s) : 0, 1097192
Total [candidate] (10.8 s) : 0, 10799730
section appsec
Agent [baseline] (1.269 s) : 0, 1268883
Total [baseline] (11.058 s) : 0, 11058221
Agent [candidate] (1.263 s) : 0, 1262513
Total [candidate] (11.041 s) : 0, 11040968
section iast
Agent [baseline] (1.223 s) : 0, 1223433
Total [baseline] (11.123 s) : 0, 11122700
Agent [candidate] (1.224 s) : 0, 1224295
Total [candidate] (11.149 s) : 0, 11149099
section profiling
Agent [baseline] (1.21 s) : 0, 1210477
Total [baseline] (10.969 s) : 0, 10969279
Agent [candidate] (1.207 s) : 0, 1206624
Total [candidate] (10.948 s) : 0, 10948142
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (652.09 ms) : 0, 652090
BytebuddyAgent [candidate] (659.725 ms) : 0, 659725
GlobalTracer [baseline] (283.076 ms) : 0, 283076
GlobalTracer [candidate] (285.808 ms) : 0, 285808
AppSec [baseline] (32.626 ms) : 0, 32626
AppSec [candidate] (33.167 ms) : 0, 33167
Debugger [baseline] (68.349 ms) : 0, 68349
Debugger [candidate] (68.082 ms) : 0, 68082
Remote Config [baseline] (641.601 µs) : 0, 642
Remote Config [candidate] (645.886 µs) : 0, 646
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (8.936 ms) : 0, 8936
Flare Poller [baseline] (3.842 ms) : 0, 3842
Flare Poller [candidate] (3.776 ms) : 0, 3776
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (691.455 ms) : 0, 691455
BytebuddyAgent [candidate] (690.273 ms) : 0, 690273
GlobalTracer [baseline] (259.882 ms) : 0, 259882
GlobalTracer [candidate] (257.949 ms) : 0, 257949
IAST [baseline] (24.784 ms) : 0, 24784
IAST [candidate] (24.48 ms) : 0, 24480
AppSec [baseline] (174.894 ms) : 0, 174894
AppSec [candidate] (173.62 ms) : 0, 173620
Debugger [baseline] (67.063 ms) : 0, 67063
Debugger [candidate] (65.745 ms) : 0, 65745
Remote Config [baseline] (791.705 µs) : 0, 792
Remote Config [candidate] (758.736 µs) : 0, 759
Telemetry [baseline] (9.502 ms) : 0, 9502
Telemetry [candidate] (9.373 ms) : 0, 9373
Flare Poller [baseline] (3.87 ms) : 0, 3870
Flare Poller [candidate] (3.765 ms) : 0, 3765
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (790.894 ms) : 0, 790894
BytebuddyAgent [candidate] (792.002 ms) : 0, 792002
GlobalTracer [baseline] (255.904 ms) : 0, 255904
GlobalTracer [candidate] (256.199 ms) : 0, 256199
IAST [baseline] (27.031 ms) : 0, 27031
IAST [candidate] (27.014 ms) : 0, 27014
AppSec [baseline] (34.715 ms) : 0, 34715
AppSec [candidate] (33.629 ms) : 0, 33629
Debugger [baseline] (65.811 ms) : 0, 65811
Debugger [candidate] (66.375 ms) : 0, 66375
Remote Config [baseline] (544.954 µs) : 0, 545
Remote Config [candidate] (587.294 µs) : 0, 587
Telemetry [baseline] (8.421 ms) : 0, 8421
Telemetry [candidate] (8.396 ms) : 0, 8396
Flare Poller [baseline] (3.554 ms) : 0, 3554
Flare Poller [candidate] (3.559 ms) : 0, 3559
section profiling
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (706.236 ms) : 0, 706236
BytebuddyAgent [candidate] (703.985 ms) : 0, 703985
GlobalTracer [baseline] (222.015 ms) : 0, 222015
GlobalTracer [candidate] (221.122 ms) : 0, 221122
AppSec [baseline] (32.44 ms) : 0, 32440
AppSec [candidate] (32.083 ms) : 0, 32083
Debugger [baseline] (67.919 ms) : 0, 67919
Debugger [candidate] (68.248 ms) : 0, 68248
Remote Config [baseline] (635.928 µs) : 0, 636
Remote Config [candidate] (652.504 µs) : 0, 653
Telemetry [baseline] (8.949 ms) : 0, 8949
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.743 ms) : 0, 3743
Flare Poller [candidate] (3.818 ms) : 0, 3818
ProfilingAgent [baseline] (97.237 ms) : 0, 97237
ProfilingAgent [candidate] (96.621 ms) : 0, 96621
Profiling [baseline] (97.813 ms) : 0, 97813
Profiling [candidate] (97.197 ms) : 0, 97197
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1185, 1208
. : milestone, 1196,
iast (3.261 ms) : 3218, 3305
. : milestone, 3261,
iast_FULL (5.729 ms) : 5673, 5786
. : milestone, 5729,
iast_GLOBAL (3.526 ms) : 3471, 3581
. : milestone, 3526,
profiling (2.088 ms) : 2069, 2107
. : milestone, 2088,
tracing (1.804 ms) : 1789, 1819
. : milestone, 1804,
section candidate
no_agent (1.206 ms) : 1194, 1218
. : milestone, 1206,
iast (3.187 ms) : 3143, 3231
. : milestone, 3187,
iast_FULL (5.85 ms) : 5791, 5908
. : milestone, 5850,
iast_GLOBAL (3.48 ms) : 3431, 3529
. : milestone, 3480,
profiling (2.054 ms) : 2036, 2072
. : milestone, 2054,
tracing (1.836 ms) : 1819, 1852
. : milestone, 1836,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section baseline
no_agent (19.342 ms) : 19142, 19541
. : milestone, 19342,
appsec (18.412 ms) : 18221, 18603
. : milestone, 18412,
code_origins (17.652 ms) : 17476, 17829
. : milestone, 17652,
iast (19.538 ms) : 19344, 19732
. : milestone, 19538,
profiling (18.393 ms) : 18211, 18576
. : milestone, 18393,
tracing (18.615 ms) : 18429, 18800
. : milestone, 18615,
section candidate
no_agent (19.358 ms) : 19157, 19560
. : milestone, 19358,
appsec (18.593 ms) : 18403, 18783
. : milestone, 18593,
code_origins (17.692 ms) : 17516, 17868
. : milestone, 17692,
iast (18.662 ms) : 18474, 18851
. : milestone, 18662,
profiling (18.618 ms) : 18435, 18801
. : milestone, 18618,
tracing (17.565 ms) : 17390, 17740
. : milestone, 17565,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section baseline
no_agent (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.457 s) : 18457000, 18457000
. : milestone, 18457000,
iast_GLOBAL (17.694 s) : 17694000, 17694000
. : milestone, 17694000,
profiling (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
tracing (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
section candidate
no_agent (15.578 s) : 15578000, 15578000
. : milestone, 15578000,
appsec (14.502 s) : 14502000, 14502000
. : milestone, 14502000,
iast (18.036 s) : 18036000, 18036000
. : milestone, 18036000,
iast_GLOBAL (17.806 s) : 17806000, 17806000
. : milestone, 17806000,
profiling (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
tracing (14.521 s) : 14521000, 14521000
. : milestone, 14521000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b79d10a3cc, baseline=1.59.0-SNAPSHOT~1c3382de68
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.719 ms) : 3499, 3938
. : milestone, 3719,
iast (2.203 ms) : 2138, 2268
. : milestone, 2203,
iast_GLOBAL (2.254 ms) : 2188, 2320
. : milestone, 2254,
profiling (2.076 ms) : 2022, 2131
. : milestone, 2076,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.727 ms) : 3507, 3948
. : milestone, 3727,
iast (2.216 ms) : 2151, 2281
. : milestone, 2216,
iast_GLOBAL (2.256 ms) : 2191, 2322
. : milestone, 2256,
profiling (2.063 ms) : 2010, 2116
. : milestone, 2063,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
6997fe7 to
a5f0d36
Compare
0ef488b to
dde4964
Compare
r1viollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The user might notice more overhead by triggering this, though as this is an explicit setting, we can add a warning in the doc.
What Does This Do
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
Motivation
There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-13347