-
Notifications
You must be signed in to change notification settings - Fork 324
[SVLS-6855] Fix Exception Replay in Lambda #10380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shreyamalpani
wants to merge
1
commit into
master
Choose a base branch
from
shreya.malpani/fix-exception-replay-in-lambda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[SVLS-6855] Fix Exception Replay in Lambda #10380
shreyamalpani
wants to merge
1
commit into
master
from
shreya.malpani/fix-exception-replay-in-lambda
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092006
Total [baseline] (8.746 s) : 0, 8746116
Agent [candidate] (1.092 s) : 0, 1091893
Total [candidate] (8.722 s) : 0, 8721570
section iast
Agent [baseline] (1.229 s) : 0, 1229465
Total [baseline] (9.319 s) : 0, 9319313
Agent [candidate] (1.223 s) : 0, 1223182
Total [candidate] (9.284 s) : 0, 9284295
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (655.054 ms) : 0, 655054
BytebuddyAgent [candidate] (657.126 ms) : 0, 657126
GlobalTracer [baseline] (284.751 ms) : 0, 284751
GlobalTracer [candidate] (283.587 ms) : 0, 283587
AppSec [baseline] (33.155 ms) : 0, 33155
AppSec [candidate] (32.724 ms) : 0, 32724
Debugger [baseline] (68.473 ms) : 0, 68473
Debugger [candidate] (68.044 ms) : 0, 68044
Remote Config [baseline] (652.128 µs) : 0, 652
Remote Config [candidate] (629.055 µs) : 0, 629
Telemetry [baseline] (9.152 ms) : 0, 9152
Telemetry [candidate] (9.022 ms) : 0, 9022
Flare Poller [baseline] (3.833 ms) : 0, 3833
Flare Poller [candidate] (3.795 ms) : 0, 3795
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (796.03 ms) : 0, 796030
BytebuddyAgent [candidate] (791.771 ms) : 0, 791771
GlobalTracer [baseline] (257.36 ms) : 0, 257360
GlobalTracer [candidate] (255.71 ms) : 0, 255710
AppSec [baseline] (33.58 ms) : 0, 33580
AppSec [candidate] (34.359 ms) : 0, 34359
Debugger [baseline] (66.039 ms) : 0, 66039
Debugger [candidate] (64.918 ms) : 0, 64918
Remote Config [baseline] (601.7 µs) : 0, 602
Remote Config [candidate] (571.401 µs) : 0, 571
Telemetry [baseline] (8.515 ms) : 0, 8515
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.529 ms) : 0, 3529
IAST [baseline] (27.188 ms) : 0, 27188
IAST [candidate] (27.224 ms) : 0, 27224
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085640
Total [baseline] (10.785 s) : 0, 10784782
Agent [candidate] (1.087 s) : 0, 1086676
Total [candidate] (10.811 s) : 0, 10811287
section appsec
Agent [baseline] (1.27 s) : 0, 1269777
Total [baseline] (11.037 s) : 0, 11036531
Agent [candidate] (1.266 s) : 0, 1266495
Total [candidate] (10.983 s) : 0, 10982737
section iast
Agent [baseline] (1.228 s) : 0, 1227729
Total [baseline] (11.209 s) : 0, 11209325
Agent [candidate] (1.226 s) : 0, 1226283
Total [candidate] (11.174 s) : 0, 11174294
section profiling
Agent [baseline] (1.211 s) : 0, 1210894
Total [baseline] (10.894 s) : 0, 10894079
Agent [candidate] (1.205 s) : 0, 1204768
Total [candidate] (10.866 s) : 0, 10866277
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (651.961 ms) : 0, 651961
BytebuddyAgent [candidate] (652.251 ms) : 0, 652251
GlobalTracer [baseline] (282.637 ms) : 0, 282637
GlobalTracer [candidate] (283.028 ms) : 0, 283028
AppSec [baseline] (32.806 ms) : 0, 32806
AppSec [candidate] (32.717 ms) : 0, 32717
Debugger [baseline] (68.119 ms) : 0, 68119
Debugger [candidate] (68.597 ms) : 0, 68597
Remote Config [baseline] (614.106 µs) : 0, 614
Remote Config [candidate] (616.799 µs) : 0, 617
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.911 ms) : 0, 8911
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.68 ms) : 0, 3680
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (694.173 ms) : 0, 694173
BytebuddyAgent [candidate] (691.4 ms) : 0, 691400
GlobalTracer [baseline] (258.076 ms) : 0, 258076
GlobalTracer [candidate] (258.581 ms) : 0, 258581
AppSec [baseline] (173.57 ms) : 0, 173570
AppSec [candidate] (174.719 ms) : 0, 174719
Debugger [baseline] (68.502 ms) : 0, 68502
Debugger [candidate] (66.549 ms) : 0, 66549
Remote Config [baseline] (777.316 µs) : 0, 777
Remote Config [candidate] (752.951 µs) : 0, 753
Telemetry [baseline] (9.596 ms) : 0, 9596
Telemetry [candidate] (9.444 ms) : 0, 9444
Flare Poller [baseline] (3.842 ms) : 0, 3842
Flare Poller [candidate] (3.799 ms) : 0, 3799
IAST [baseline] (24.438 ms) : 0, 24438
IAST [candidate] (24.584 ms) : 0, 24584
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (792.995 ms) : 0, 792995
BytebuddyAgent [candidate] (793.052 ms) : 0, 793052
GlobalTracer [baseline] (257.117 ms) : 0, 257117
GlobalTracer [candidate] (256.448 ms) : 0, 256448
AppSec [baseline] (33.809 ms) : 0, 33809
AppSec [candidate] (33.651 ms) : 0, 33651
Debugger [baseline] (67.242 ms) : 0, 67242
Debugger [candidate] (66.601 ms) : 0, 66601
Remote Config [baseline] (567.92 µs) : 0, 568
Remote Config [candidate] (555.896 µs) : 0, 556
Telemetry [baseline] (8.522 ms) : 0, 8522
Telemetry [candidate] (8.506 ms) : 0, 8506
Flare Poller [baseline] (3.555 ms) : 0, 3555
Flare Poller [candidate] (3.546 ms) : 0, 3546
IAST [baseline] (27.159 ms) : 0, 27159
IAST [candidate] (27.158 ms) : 0, 27158
section profiling
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (707.206 ms) : 0, 707206
BytebuddyAgent [candidate] (702.989 ms) : 0, 702989
GlobalTracer [baseline] (221.781 ms) : 0, 221781
GlobalTracer [candidate] (220.494 ms) : 0, 220494
AppSec [baseline] (32.376 ms) : 0, 32376
AppSec [candidate] (32.012 ms) : 0, 32012
Debugger [baseline] (68.192 ms) : 0, 68192
Debugger [candidate] (68.001 ms) : 0, 68001
Remote Config [baseline] (631.045 µs) : 0, 631
Remote Config [candidate] (632.248 µs) : 0, 632
Telemetry [baseline] (8.802 ms) : 0, 8802
Telemetry [candidate] (8.761 ms) : 0, 8761
Flare Poller [baseline] (3.648 ms) : 0, 3648
Flare Poller [candidate] (3.69 ms) : 0, 3690
ProfilingAgent [baseline] (96.576 ms) : 0, 96576
ProfilingAgent [candidate] (97.118 ms) : 0, 97118
Profiling [baseline] (97.158 ms) : 0, 97158
Profiling [candidate] (97.689 ms) : 0, 97689
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (17.909 ms) : 17728, 18090
. : milestone, 17909,
appsec (19.547 ms) : 19351, 19743
. : milestone, 19547,
code_origins (18.102 ms) : 17926, 18279
. : milestone, 18102,
iast (17.879 ms) : 17702, 18057
. : milestone, 17879,
profiling (18.827 ms) : 18635, 19020
. : milestone, 18827,
tracing (17.722 ms) : 17544, 17899
. : milestone, 17722,
section candidate
no_agent (17.377 ms) : 17199, 17555
. : milestone, 17377,
appsec (18.751 ms) : 18558, 18944
. : milestone, 18751,
code_origins (17.547 ms) : 17372, 17723
. : milestone, 17547,
iast (17.643 ms) : 17467, 17818
. : milestone, 17643,
profiling (18.673 ms) : 18487, 18858
. : milestone, 18673,
tracing (17.714 ms) : 17538, 17889
. : milestone, 17714,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.164 ms) : 1153, 1175
. : milestone, 1164,
iast (3.157 ms) : 3112, 3203
. : milestone, 3157,
iast_FULL (5.656 ms) : 5601, 5712
. : milestone, 5656,
iast_GLOBAL (3.504 ms) : 3454, 3553
. : milestone, 3504,
profiling (1.954 ms) : 1937, 1971
. : milestone, 1954,
tracing (1.852 ms) : 1834, 1870
. : milestone, 1852,
section candidate
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (3.289 ms) : 3250, 3328
. : milestone, 3289,
iast_FULL (5.97 ms) : 5909, 6031
. : milestone, 5970,
iast_GLOBAL (3.56 ms) : 3505, 3615
. : milestone, 3560,
profiling (2.058 ms) : 2039, 2077
. : milestone, 2058,
tracing (1.795 ms) : 1779, 1811
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.647 ms) : 3432, 3861
. : milestone, 3647,
iast (2.213 ms) : 2148, 2279
. : milestone, 2213,
iast_GLOBAL (2.26 ms) : 2195, 2325
. : milestone, 2260,
profiling (2.056 ms) : 2004, 2109
. : milestone, 2056,
tracing (2.036 ms) : 1985, 2087
. : milestone, 2036,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.627 ms) : 3412, 3842
. : milestone, 3627,
iast (2.207 ms) : 2142, 2271
. : milestone, 2207,
iast_GLOBAL (2.25 ms) : 2185, 2315
. : milestone, 2250,
profiling (2.482 ms) : 2318, 2646
. : milestone, 2482,
tracing (2.05 ms) : 1998, 2101
. : milestone, 2050,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~446bbc6711, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
appsec (14.661 s) : 14661000, 14661000
. : milestone, 14661000,
iast (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
iast_GLOBAL (17.624 s) : 17624000, 17624000
. : milestone, 17624000,
profiling (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
tracing (14.646 s) : 14646000, 14646000
. : milestone, 14646000,
section candidate
no_agent (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
appsec (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
iast (18.002 s) : 18002000, 18002000
. : milestone, 18002000,
iast_GLOBAL (17.632 s) : 17632000, 17632000
. : milestone, 17632000,
profiling (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
tracing (14.538 s) : 14538000, 14538000
. : milestone, 14538000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]