Skip to content

Use slf4j-simple instead of logback that has a high chance of getting stuck in a deadlock on CI. #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexeyKuznetsov-DD wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use slf4j-simple instead of logback that has a high chance of getting stuck in a deadlock on CI. #10390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec2b7ec
Use slf4j-simple as default; logback has a high chance of getting stu…
AlexeyKuznetsov-DD Jan 15, 2026
00d4a72
Relaxed checks for Logback.
AlexeyKuznetsov-DD Jan 15, 2026
e141dcb
Merge branch 'master' into alexeyk/vertx-web-3.4-tests-logger
AlexeyKuznetsov-DD Jan 16, 2026
f6a5422
Minor.
AlexeyKuznetsov-DD Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ...-fixtures/src/main/groovy/com/datadog/iast/test/IastRequestContextPreparationTrait.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,19 @@ import com.datadog.iast.IastSystem
import com.datadog.iast.model.Range
import com.datadog.iast.taint.TaintedObject
import com.datadog.iast.taint.TaintedObjects
import datadog.trace.api.gateway.*
import datadog.trace.api.gateway.CallbackProvider
import datadog.trace.api.gateway.EventType
import datadog.trace.api.gateway.Events
import datadog.trace.api.gateway.Flow
import datadog.trace.api.gateway.IGSpanInfo
import datadog.trace.api.gateway.RequestContext
import datadog.trace.api.gateway.RequestContextSlot
import datadog.trace.api.iast.InstrumentationBridge
import datadog.trace.bootstrap.instrumentation.api.AgentTracer
import org.slf4j.Logger
import org.slf4j.LoggerFactory

import java.util.function.BiFunction
import java.util.function.Supplier
import org.slf4j.Logger
import org.slf4j.LoggerFactory

trait IastRequestContextPreparationTrait {

Expand Down Expand Up @@ -73,7 +78,9 @@ trait IastRequestContextPreparationTrait {

private static Logger withLogger(final String name) {
final logger = LoggerFactory.getLogger(name)
if (logger instanceof ch.qos.logback.classic.Logger) {

// Check logger class by name to avoid NoClassDefFoundError at runtime for tests without Logback.
if (logger.class.name == "ch.qos.logback.classic.Logger") {
((ch.qos.logback.classic.Logger) logger).level = ch.qos.logback.classic.Level.DEBUG
}
return logger
Expand Down
3 changes: 3 additions & 0 deletions dd-java-agent/instrumentation/vertx/vertx-web/vertx-web-3.4/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
apply from: "$rootDir/gradle/java.gradle"
// Use slf4j-simple as default; logback has a high chance of getting stuck in a deadlock on CI.
apply from: "$rootDir/gradle/slf4j-simple.gradle"

testJvmConstraints {
// TODO Java 17: This version of vertx-web doesn't support Java 17
Expand Down Expand Up @@ -49,3 +51,4 @@ dependencies {
latestDepTestImplementation group: 'io.vertx', name: 'vertx-web', version: '3.+'
latestDepTestImplementation group: 'io.vertx', name: 'vertx-web-client', version: '3.+'
}

29 changes: 17 additions & 12 deletions internal-api/src/main/java/datadog/trace/api/iast/Taintable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,23 @@ class DebugLogger {
private static final Logger LOGGER;

static {
try {
LOGGER = LoggerFactory.getLogger("Taintable tainted objects");
Class<?> levelCls = Class.forName("ch.qos.logback.classic.Level");
Method setLevel = LOGGER.getClass().getMethod("setLevel", levelCls);
Object debugLevel = levelCls.getField("DEBUG").get(null);
setLevel.invoke(LOGGER, debugLevel);
} catch (IllegalAccessException
| NoSuchFieldException
| ClassNotFoundException
| NoSuchMethodException
| InvocationTargetException e) {
throw new RuntimeException(e);
LOGGER = LoggerFactory.getLogger("Taintable tainted objects");

// Check logger class by name to avoid NoClassDefFoundError at runtime
// for tests without Logback.
if (LOGGER.getClass().getName().equals("ch.qos.logback.classic.Logger")) {
Copy link
Contributor

@bric3 bric3 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Mostly to IAST folk, does it makes sense to support additional loggers ?

E.g. https://github.com/qos-ch/slf4j/blob/master/slf4j-simple/src/main/java/org/slf4j/simple/SimpleLogger.java

Same for https://github.com/DataDog/dd-trace-java/pull/10390/changes#diff-3184e5348b8ced794d3398d54e5feb997c7fad5967ad52f64cafd53526263c41R83

try {
Class<?> levelCls = Class.forName("ch.qos.logback.classic.Level");
Method setLevel = LOGGER.getClass().getMethod("setLevel", levelCls);
Object debugLevel = levelCls.getField("DEBUG").get(null);
setLevel.invoke(LOGGER, debugLevel);
} catch (IllegalAccessException
| NoSuchFieldException
| ClassNotFoundException
| NoSuchMethodException
| InvocationTargetException e) {
throw new RuntimeException(e);
}
}
}

Expand Down