-
Notifications
You must be signed in to change notification settings - Fork 16
feat(profiling-ffi): add process_tags to ffi debbuger payload #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2026-01-30 16:15:11 Comparing candidate commit 56b44af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
- Coverage 71.04% 71.02% -0.02%
==========================================
Files 422 422
Lines 68697 68704 +7
==========================================
- Hits 48804 48797 -7
- Misses 19893 19907 +14
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
|
The libdatadog branch was 15 days behind main so I updated it, tests are rerunning. |
morrisonlevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part looks good, I haven't reviewed the PHP side yet.
Note that the libdatadog branch was 15 days behind main so I updated it, tests are rerunning.
What does this PR do?
dd-trace-php is using libdatadog to send its debugger payload. We want to send process_tags in every debugger payload according to this RFC for dynamic instrumentation. This PR is adding process tags support in the live debugger part of libdatadog.
How to test the change?
The changes are tested directly in dd-trace-php through this PR: DataDog/dd-trace-php#3580