feat: update MCP tool params to inheriet all zodSchema parameters#520
Merged
jonathannorris merged 2 commits intomainfrom Sep 16, 2025
Merged
feat: update MCP tool params to inheriet all zodSchema parameters#520jonathannorris merged 2 commits intomainfrom
jonathannorris merged 2 commits intomainfrom
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 5961f3b | Sep 16 2025, 08:06 PM |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCP types to auto-inherit parameters from zodSchemas instead of manually redefining them, with the ability to override parameters that need specific descriptions.
- Replaces manual object creation with
.extend()to inherit all parameters from base schemas - Adds missing parameters (persistent, tags) to variable schemas and updates their descriptions
- Moves GetProjectsParams definition from zodClientAPI.ts to zodSchemas.ts for better organization
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp/types.ts | Updates all MCP argument schemas to use .extend() for automatic parameter inheritance |
| src/commands/projects/get.ts | Updates import path for GetProjectsParams |
| src/api/zodSchemas.ts | Adds GetProjectsParams definition and various schema improvements |
| src/api/zodClientAPI.ts | Removes GetProjectsParams definition (moved to zodSchemas.ts) |
| src/api/schemas.ts | Updates import path for GetProjectsParams |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JamieSinn
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5d83e55 to
c4d55ca
Compare
c192137 to
17b64db
Compare
600853a to
f215dce
Compare
a2ff02f to
4a9905d
Compare
f215dce to
fe2c5a9
Compare
4a9905d to
a37901b
Compare
64f5e81 to
9fc7a16
Compare
a37901b to
6807c80
Compare
Base automatically changed from
docs-update-delete-variable-description
to
main
September 16, 2025 20:03
6807c80 to
5961f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types.tsto by default auto-inherit new params from thezodSchemas.tsand just overwrite params that need descriptions.z.record(z.unknown())instead ofz.object({}).partial().passthrough()