Changed button hover/focus states#94
Open
JoleneKearse wants to merge 1 commit intoDeveloperAshish8:mainfrom
Open
Changed button hover/focus states#94JoleneKearse wants to merge 1 commit intoDeveloperAshish8:mainfrom
JoleneKearse wants to merge 1 commit intoDeveloperAshish8:mainfrom
Conversation
Saksh8
referenced
this pull request
in Saksh8/CodeChamp-s-Website
Oct 4, 2022
Hey, I have made a grammatical correction in line #94 by adding an "and" term. Also, I have added a few lines and adjectives in #93, #94, and #95 to make the description of CodeChamp more impactful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I found the button hover states made it a bit hard to see the button. Some users might have a hard time knowing when they are on the button to click.
I added a small border to make the button's area easy to see. I also added a focus state with the same styling.