DS-5479: Fix shapley code to allow RcppEigen upgrade #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility issues with newer versions of RcppEigen by adding explicit type casts and removes version constraints. The changes address compilation errors that occur when upgrading from the previously pinned RcppEigen version.
- Added
static_cast<int>conversions for array indexing operations - Removed RcppEigen version constraint to allow upgrades
- Cleaned up trailing whitespace
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/shapley.cpp | Added explicit integer type casts for array indexing and removed trailing whitespace |
| DESCRIPTION | Bumped package version and removed RcppEigen version constraint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
instantepiphany
approved these changes
Sep 30, 2025
Contributor
instantepiphany
left a comment
instantepiphany
left a comment
There was a problem hiding this comment.
Very cool to see this resolved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build issue of the shapley C++ code with the new RcppEigen dependency. Will allow RcppEigen to be unpinned.