Conversation
nathanaelren
left a comment
nathanaelren
left a comment
There was a problem hiding this comment.
I think we could consider rewrite lane_marker_detector.py to extend our generic hsv_filter.py, and moving to a more generic runType launch argument to enable customization beyond "yes prequal" and "no prequal" within the same launch argument. @viethungle-vt1401 lmk thoughts
There was a problem hiding this comment.
If possible, I think it would be good to have this file re-written using the new HSV filter template to standardize all of our HSV filtering this year. Especially if we can have somebody who doesn't currently understand the CV pipeline help write this. @viethungle-vt1401 do you think this is reasonable? Or do you prefer to just prequal with this code
There was a problem hiding this comment.
Sounds like a good idea, though revamping prequal code is not the highest priority so I'm fine either way. I can rope someone to work on it while we are testing other stuff and/or before Crush prequal.
|
|
||
| ld = LaunchDescription() | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( |
There was a problem hiding this comment.
@viethungle-vt1401 I think instead of having "prequal=Boolean", we could consider having "typeOfRun=string", and do "typeOfRun=prequal" etc., I think this might be a bit cleaner if we want to continue to use this schema for, e.g., comp run or something of the sort.
|
|
||
| ld = LaunchDescription() | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( |
There was a problem hiding this comment.
See comment on cv.launch.py
| description='Enable or disable recording functionality', | ||
| )) | ||
|
|
||
| ld.add_action(DeclareLaunchArgument( |
There was a problem hiding this comment.
See comment on cv.launch.py
|
|
||
| ld.add_action(IncludeLaunchDescription( | ||
| PythonLaunchDescriptionSource(str(pkg_cv / 'launch' / 'cv.launch.py')), | ||
| launch_arguments=[ |
There was a problem hiding this comment.
We would need to do LaunchConfiguration('runType') == 'prequal' or something of the sort should we move in that direction, see comment on cv.launch.py. This change would also need to be reflected in the other relevant launch files (cv.launch.py, usb_camera_detectors.launch.py).
* Robot Agnostic Foxglove (#108) * Robot agnostic support * Robot agnostic support * Add status timeout * Copy topic on click * Deprecate call-service-panel and subscribe-topic-panel * Update foxglove/extensions/system-status-panel/src/SystemStatusPanel.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add buttons to set ROBOT_NAME * Add toasts for copy action * Disable buttons when callService unavailable * Initial attempt at automatic deployement * Add test branch * Remove variable check * Only publish on pushes to main * Rename * Update docs * Update docs * Delete sonar_plot.png (#110) * WIP new HSV Refactoring * Skeleton hsv_lane_marker.py code * Address Max's comments * Added additional publishers * Updated countor processing * Clean up code for hsv_lane_marker's process_contours * Updated publishers in the process contour method * Update launch -- kept the info for launching lane_marker_detector.py but got rid of it from setup.py * Removed double quotes * Move hsv scripts into hsv_filters * Adjusted setup.py to reflect new structure of the cv package * Linted --------- Co-authored-by: Maxwell Lin <git@maxwellmlin.com> Co-authored-by: Viet Hung Le <brandon.viethungRI2001@gmail.com> Co-authored-by: Pranav Bijith <pranavbijith1@gmail.com>
5 participants
Draft PR for adjustments made to complete prequal.