fix validate_data and force_all_finite warnings#78
Closed
saleha1wer wants to merge 1 commit intoEBjerrum:mainfrom
Closed
fix validate_data and force_all_finite warnings#78saleha1wer wants to merge 1 commit intoEBjerrum:mainfrom
saleha1wer wants to merge 1 commit intoEBjerrum:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Owner
|
Thanks for the contribution, but could you possibly divide it up into two PR's? For added _validate_data() we need to make a deeper evalutation if we want to bump sklearn requirement to >=1.6, which could take some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added _validate_data() override in BaseApplicabilityDomain. This addresses the depreciation warning but would mean scikit-learn ≥ 1.6 is required now
replaced force_all_finite with ensure_all_finite (FutureWarning)