-
Notifications
You must be signed in to change notification settings - Fork 26
Add functionality for updating an existing compatibility layer #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes EESSI#226 Since this is pretty relevant to security, I am inclined to point these variable symlinks to `/dev/null` by default but that does not actually address the problem being discussed in EESSI#226 (having to harass the admins to link the CUDA drivers). If we can have logic in our CVMFS configuration then maybe we can address that.
|
Tried it with a bind mount from the host, but that doesn't work, as the files are then owned by the cvmfs user. This leads to all sorts of permission errors in the Prefix environment, e.g. |
d9288eb to
3d15aa0
Compare
|
bot: build repo:eessi.io-2025.06-compat instance:eessi-bot-mc-aws for:arch=x86_64/generic |
|
New job on instance
|
|
bot: build repo:eessi.io-2025.06-compat instance:eessi-bot-mc-aws for:arch=x86_64/generic |
|
New job on instance
|
casparvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed Bob would add some comments for clarity, but otherwise this looks fine. Deploying!
|
Just to summarize, the plan is to do the following to follow up on this PR:
are on the runtime linker search path. We'll add those dirs as variant symlinks, which by default point to a single, version-aspecific location (this location has to be inside the These default locations are again variant symlinks that point to With this, sites can choose if they want their nvidia, amd and override symlinks to be version specific (in which case they'd set The latter (i.e. only setting the defaults) is probably a good starting point - and then sites can set the version-specific symlinks only if they have a good reason for it. Using the defaults means you only have to symlink the nvidia drivers once, and not once per EESSI version. |
@casparvl Please make that an issue, don't try to keep track of things in merged PRs (I need to mention that as bad advice in a future talk somewhere...) |
|
Well, it's basically just a clarification of #227 (comment) (which was made in a PR that got replaced by this PR). Essentially, the work is done in this PR. It's just about providing context about why these new trusted dirs were introduced - and that's context I would like to have exactly in the PR that introduced them ;-) Honestly, I considered putting it in the opening post as motivation why we even made this PR. The fact that this requires some follow-up to actually exploit this new feature is a detail - and no need to log it, I'm working on that already ;-) |
|
The more important place where to put this is in the documentation. But that's also on my TODO list (asap), but only worth once the change to |
Attempt to make it possible to rerun the playbook on top of an existing compat layer. Will require some changes in the installation script, as it now bind mounts an empty host dir as
/cvmfs/software.eessi.io, instead it should probably just fusemount the CVMFS repo inside the container.This PR includes the commits from PR #227 as a test case.