Update uniqueness_gtest output, remove datadr and trelliscope#34
Merged
Update uniqueness_gtest output, remove datadr and trelliscope#34
Conversation
…ts; began updating relevant tests
…o list. Updated associated tests. Fixed a typo from divideByGroup
…dr DDO structure. Updated associated tests.
remove lingering references and code for datadr/trelliscope
clabornd
force-pushed
the
remove_ddr_trell
branch
from
9056449 to
0edeefd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove datadr and trelliscope: All datadr operations are now just
lapplyand output lists instead ofddo. Calls and references to trelliscope functions removed.Update uniqueness_gtest:
uniqueness_gtest and all functions that wrap it now output extra columns:
pval,N_grp1,N_grp2for the p-value, and number present in each group for a particular comparison.@stratkg Second item addresses what we talked about - there was not an object that held p-values from the G-test that we could display in the app. I will try to integrate/deploy this change in FREDA next week.
closes #24