Skip to content

Conversation

@ndench
Copy link
Contributor

@ndench ndench commented Jul 12, 2023

Draft PR to go along with #5835

TODO (if we want to move forward with this feature request):

  • Support other comparison types (NEQ, CONTAINS, etc)
  • Support multiple choices
  • Allow limiting the available countries/timezones/currencies
  • Write tests

@javiereguiluz
Copy link
Collaborator

@ndench thanks for proposing this feature. I like it and I'll help you with anything you need to complete this.

From the list of things to do, I'd say that:

  • Support other comparison types (NEQ, CONTAINS, etc): Nice to have if not very complex
  • Support multiple choices: Nice to have if not very complex
  • Allow limiting the available countries/timezones/currencies: Let's leave it for the future unless trivial to implement
  • Write tests: Not mandatory to merge this, let's do it only if not very complex

Thanks!

@javiereguiluz javiereguiluz added this to the 4.x milestone Sep 7, 2023
@javiereguiluz
Copy link
Collaborator

@ndench thanks for this contribution! Recently, I needed this feature myself so I'd love to see it implemented soon. That's why I created a new PR to add this and other Intl-related filters. See #7362.

Soi, I'm closing this PR in favor of the other one. Thanks!

@ndench
Copy link
Contributor Author

ndench commented Jan 14, 2026

That's awesome, thanks @javiereguiluz. Apologies I have been unable to make time to finish this off myself. But your approach looks much better than what I would have done anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants