rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses #1522
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested ACK a4eeed9 |
delta1
force-pushed
the
2026-01-tweakfedpegscript
branch
from
a4eeed9 to
f2bd052
Compare
delta1
changed the title
|
NACK a4eeed9, have read the diff |
jsarenik
suggested changes
Jan 20, 2026
jsarenik
left a comment
jsarenik
left a comment
There was a problem hiding this comment.
p2shwsh seems very non-standard and I do not know what is meant by that. Did you mean following?
sh(wpkh), Nested Segwit, P2SH-segwit
(all above are the same thing, how people call it, better do not add another)
Member
Author
|
It's wrapped segwit. |
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of the tweaked address. "address" has been removed from the result and replaced with "p2wsh" and "p2shwsh".
delta1
force-pushed
the
2026-01-tweakfedpegscript
branch
from
f2bd052 to
5d64e89
Compare
Member
|
Tested ACK 5d64e89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of
the tweaked address.
"address" has been removed from the tweakfedpegscript RPC result and replaced with "p2wsh" and
"p2shwsh" addresses.