Fixed weird animation in moveCurrentBarView when isInfinity is true#80
Open
masatootake wants to merge 1 commit intoEndouMari:masterfrom
Open
Fixed weird animation in moveCurrentBarView when isInfinity is true#80masatootake wants to merge 1 commit intoEndouMari:masterfrom
masatootake wants to merge 1 commit intoEndouMari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess it's just a mistake. The following code is using
index, but it should becurrentIndex.https://github.com/EndouMari/TabPageViewController/blob/master/Sources/TabView.swift#L224
The below is the exact part.
As a result of this mistake, when
isInfinityis true, it causes a weird animation when moving tab from the range ofpageTabItemsCount <= currentIndex < pageTabItemsCount * 2to the range ofcurrentIndex < pageTabItemsCount && pageTabItemsCount * 2 <= currentIndex.