Skip to content

fix: build issues with -fmodules flag #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greghuels merged 3 commits into from
Jan 13, 2026
Merged

fix: build issues with -fmodules flag #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7427ade
fix: build issues with `-fmodules` flag
greghuels Jan 13, 2026
d7b9799
chore: CI verification to make sure library builds with modules enabled
greghuels Jan 13, 2026
a1c32f6
Update .github/workflows/test.yml
greghuels Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,26 @@ jobs:

- name: Run memory tests
run: make test-memory TEST_DATA_BRANCH=${{env.TEST_DATA_BRANCH_NAME}}

cxx-modules-test:
runs-on: macos-latest
name: Build with C++20 modules

steps:
- name: Checkout code
uses: actions/checkout@v6
with:
repository: ${{ github.event.pull_request.head.repo.full_name || 'Eppo-exp/cpp-sdk' }}
ref: ${{ env.SDK_BRANCH_NAME }}

- name: Set up build environment
run: |
brew install re2
brew install cmake

- name: Build with -fmodules flag
run: |
mkdir -p build-modules
cd build-modules
cmake .. -DCMAKE_CXX_FLAGS="-fmodules" -DEPPOCLIENT_BUILD_TESTS=OFF -DEPPOCLIENT_ERR_ON_WARNINGS=OFF
cmake --build .
2 changes: 2 additions & 0 deletions third_party/nlohmann/json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6159,6 +6159,7 @@ NLOHMANN_JSON_NAMESPACE_END
#ifndef JSON_NO_IO
#include <cstdio> // FILE *
#include <istream> // istream
#include <streambuf> // streambuf
#endif // JSON_NO_IO

// #include <nlohmann/detail/iterators/iterator_traits.hpp>
Expand Down Expand Up @@ -7378,6 +7379,7 @@ NLOHMANN_JSON_NAMESPACE_END
#include <array> // array
#include <clocale> // localeconv
#include <cstddef> // size_t
#include <cerrno> // errno
#include <cstdio> // snprintf
#include <cstdlib> // strtof, strtod, strtold, strtoll, strtoull
#include <initializer_list> // initializer_list
Expand Down
Loading