Skip to content

Conversation

@aarsilv
Copy link
Contributor

@aarsilv aarsilv commented Dec 28, 2025

Eppo Internal:
🎟️ Ticket: FFESUPPORT-419 - Address node-server-sdk high vulnerabilities

Motivation and Context

Address the following vulnerabilities:

Description

Upgrade dev dependency @google-cloud/storage which is what contained these vulnerabilities

How has this been documented?

n/a

How has this been tested?

Existing automated tests

@aarsilv aarsilv marked this pull request as ready for review December 28, 2025 01:57
Copy link
Contributor

@greghuels greghuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jws is already upgraded to 4.0.1 by upgradging @google-cloud/storage, so we shouldn't explicitly add jws to the dependencies of this package.

package.json Outdated
"dependencies": {
"@eppo/js-client-sdk-common": "4.15.2"
"@eppo/js-client-sdk-common": "4.15.2",
"jws": "^4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jws is already upgraded to 4.0.1 by upgradging @google-cloud/storage, so this line should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch!

@greghuels greghuels assigned aarsilv and unassigned greghuels Dec 30, 2025
@aarsilv aarsilv merged commit 0992f27 into main Dec 30, 2025
8 checks passed
@aarsilv aarsilv deleted the aarsilv/ffesupport-419/address-high-dependency-vulnerabilities branch December 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants