fix: improve PHP 8.4 stream timeout handling (issue #131)#140
Open
sonarta wants to merge 1 commit intoEvilFreelancer:masterfrom
Open
fix: improve PHP 8.4 stream timeout handling (issue #131)#140sonarta wants to merge 1 commit intoEvilFreelancer:masterfrom
sonarta wants to merge 1 commit intoEvilFreelancer:masterfrom
Conversation
- Replace socket_get_status() with stream_get_meta_data() for clarity - Only throw timeout exception when timed_out=true AND no data received - Add configurable 'throw_timeout_exception' option to disable timeout checks - Update Laravel config with ROUTEROS_THROW_TIMEOUT_EXCEPTION env var Tested on PHP 8.4.15 with RouterOS 7.12.1, retrieved 72,788 records successfully. Fixes: EvilFreelancer#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users report
StreamException: Stream timed outerror when using PHP 8.4, particularly when retrieving large amounts of data.Solution
socket_get_status()withstream_get_meta_data()for claritythrow_timeout_exceptionoptionTesting
Tested on PHP 8.4.15 with RouterOS 7.12.1:
Usage
If issues persist, disable timeout exception:
Fixes #131