fix: android-headless-talkback-accessibility #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TaduJR Please merge main into your branch to fix the GitHub validation errors? |
eVoloshchak
reviewed
Jan 27, 2026
| } | ||
| }; | ||
|
|
||
| const accessibilityLabel = selectedItem.inputLabel || selectedItem.label; |
There was a problem hiding this comment.
Let's just pass whatever accessibilityLabel we pass to RNPickerSelect manually
<RNPickerSelect
pickerProps={{
accessibilityLabel: selectedItem.title,
}}
>
eVoloshchak
reviewed
Jan 27, 2026
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityState={{ disabled }} | ||
| onAccessibilityAction={handleAccessibilityAction} | ||
| accessibilityActions={[{ name: 'activate' }]} |
There was a problem hiding this comment.
Should we add support for 'escape' action too?
|
@TaduJR Please can we get some movement on this. |
Author
|
Hey @inimaga Very sorry for the delay 🙏 I was having some deploy blockers recently. Will surely handle it tomorrow. Thanks for the bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Expensify/App#77542
Demo:
Screen_Recording_20260122_065943_New.Expensify.Dev.mp4