Fixing power-law + peak model and adding a chi_eff distribution to gwpopulation.py #54
Open
sharanbngr wants to merge 1 commit intoFarrOutLab:mainfrom
Open
Fixing power-law + peak model and adding a chi_eff distribution to gwpopulation.py #54sharanbngr wants to merge 1 commit intoFarrOutLab:mainfrom
sharanbngr wants to merge 1 commit intoFarrOutLab:mainfrom
Conversation
…2. adding a model for chi_eff distribution
Collaborator
|
Sorry it's taken us so long to get to the PR @sharanbngr! Unsurprisingly, a lot has changed since you initiated your PR in February!
def chi_eff_truncnorm(chi_eff, mu=0, sig=1):
return truncnorm_pdf(chi_eff, mu, sig, -1, 1)We've moved the parametric models to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things.
First the powerlaw needs to be normalized in the powerlaw + peak model for correct inference. The Gaussian in the peak is already normalized.
Adding a model for chi_eff distribution