add SCSS codepoint map in addition to the variables#319
Open
odedniv wants to merge 1 commit intoFontCustom:masterfrom
Open
add SCSS codepoint map in addition to the variables#319odedniv wants to merge 1 commit intoFontCustom:masterfrom
odedniv wants to merge 1 commit intoFontCustom:masterfrom
Conversation
Collaborator
|
This is a good addition. Please rebase master to resolve conflicts and fix the build. |
odedniv
force-pushed
the
scss-codepoint-map
branch
from
4ad8616 to
0d4d70f
Compare
Author
|
Done. I don't fully remember what I did here, if it looks good for you great, if you're not sure either let me know and I'll have a closer look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to properly use the glyph codes from an SCSS dynamically, you need a map.
I also needed the glyph_properties so as a bonus I added a generic class that you can extend according to the configurable class name but without a glyph name. This generates something like
.icon-. I wanted to use.icon-propertiesbut I was afraid of breaking someone's icon with the same name.Also added this functionality to the rails version.