Open
Conversation
Prevent boilerplace code for constructing comples (A AND (B OR C)) queries and enforce parenthesis by - wrapping multiple matches into another match (enforces "( many matches )") via matchAndMatch() - helper for field IN selector to build match code for "@field A | B | C", to get rid of boilerplace everytime (cant do orMatch, must first ->match) Feel free to rename the functions, i find them usefull in my project to prevent boilerplace ``` $matches = []; $matches[] = $sphql->matchFieldIN('field_a', [1,2,3]); $matches[] = $sphql->matchFieldIN('field_b', [4,5,6]); $sphql->resetMatch()->match($sphql->matchAndMatch($matches)); //generates ("(@field_a 1 | 2 | 3) (@field_b 4 | 5 | 6)") without boilerplate // (A1 AND (B2 OR C3)) still needs boilerplace like this $mymatch = (new Match($sphql))->match($mymatch1) ->orMatch() ->match((new Match($sphql))->match($mymatch2)->orMatch($mymatch3)); ```
|
The inspection completed: 5 new issues, 2 updated code elements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent boilerplace code for constructing comples (A AND (B OR C)) queries and enforce parenthesis by
Feel free to rename the functions, i find them usefull in my project to prevent boilerplace