Adjust default fee allocation percentages in finaliseSale#32
Open
leonnleite wants to merge 1 commit intoGalaChain:mainfrom
Open
Adjust default fee allocation percentages in finaliseSale#32leonnleite wants to merge 1 commit intoGalaChain:mainfrom
leonnleite wants to merge 1 commit intoGalaChain:mainfrom
Conversation
Jehosephat
approved these changes
Nov 6, 2025
Collaborator
Jehosephat
left a comment
Jehosephat
left a comment
There was a problem hiding this comment.
Ultimately these values should be coming from the configuration object (LaunchpadFinalizeFeeAllocation). This config object can be set by the curator.
leonnleite
force-pushed
the
fix/owner-percentage
branch
from
e26f3e3 to
8591bd7
Compare
Jehosephat
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update modifies the default fee allocation percentages used in the
finaliseSale.tsfile.The default values for
ownerAllocationPercentageandliquidityAllocationPercentagehave been adjusted to better align with the updated fee distribution model.Specifically:
ownerAllocationPercentagewas reduced from 0.05 to 0.01.liquidityAllocationPercentagewas increased from 0.94 to 0.98.These changes ensure that the platform and liquidity pools receive appropriate allocations when
feeAllocationis not explicitly defined.