Skip to content

PartitionManager: Add safety checks to prevent access violations in iterateCellsBreadthFirst and getNearestGroupWithValue#117

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/partitionmanagersafetychecks
Open

PartitionManager: Add safety checks to prevent access violations in iterateCellsBreadthFirst and getNearestGroupWithValue#117
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/partitionmanagersafetychecks

Conversation

@seer-by-sentry
Copy link

@seer-by-sentry seer-by-sentry bot commented Nov 8, 2025

Fixes CLIENT-S6. The issue was that: Access violation read in PartitionManager::iterateCellsBreadthFirst due to calling a member function on an invalid or uninitialized ThePartitionManager singleton instance.

  • Added null checks for input parameters (pos, m_cells, proc) in iterateCellsBreadthFirst to prevent crashes.
  • Added bounds checks for starting cell coordinates (cellX, cellY) in iterateCellsBreadthFirst to prevent out-of-bounds access.
  • Added validation for cellCount in iterateCellsBreadthFirst to prevent invalid memory access.
  • Added null check for curCell within the main loop of iterateCellsBreadthFirst.
  • Added null check for m_cells in getNearestGroupWithValue.
  • Added bounds check for nearestGreat before accessing m_cells in getNearestGroupWithValue.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2523071

Not quite right? Click here to continue debugging with Seer.

…terateCellsBreadthFirst and getNearestGroupWithValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants