Conversation
nuest
requested changes
Jun 2, 2025
| ) | ||
| try: | ||
| from wikibaseintegrator.datatypes import Url | ||
| except ImportError: |
Member
There was a problem hiding this comment.
Why not go with the second one right-away?
| def add_time_claims(dates, prop_nr, statements): | ||
| for ds in dates: | ||
| iso, prec = normalize_date_and_precision(ds) | ||
| timestamp = f"+{iso}T00:00:00Z" |
Member
There was a problem hiding this comment.
Despite the above, I'm fine with the hours/mins/seconds here are the same for beginning and end. We operate at day-level precision.
Implements functionality to export publication metadata to a Wikibase instance, including Wikidata
nuest
force-pushed
the
features/export_wikidata
branch
from
8d2e571 to
0ad4b17
Compare
…nts/center to wikidata
nuest
force-pushed
the
features/export_wikidata
branch
from
0ad4b17 to
6b1e930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113