Open
Conversation
Member
|
Nice feature for users wanting to tweak (I wish all Shiny apps I use came with this!); script looks great. I was able to successfully step through it and generate the plot.
|
gadenbuie
commented
Jan 2, 2019
| dat <- dat[dat$rsID %in% snps, ] | ||
| snp_pos <- dat$pos_hg38 | ||
| tad <- tad[tad$chr == max(dat$chr, na.rm = TRUE), ] | ||
| tad[tad$start_position <= snp_pos & tad$end_position >= snp_pos, ] |
Member
Author
There was a problem hiding this comment.
@jhcreed This line (and the similar line in in_lad() throw warnings when snp_pos has length > 1 (both in script and app). When length(snp_pos) > 1, I think only the first element is used, so in_tad() only checks the first SNP. You may want to investigate to verify that this is the case or the desired behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the key elements from the Shiny app into an RScript template. The input values of the app are written into the template before downloading (just the relevant inputs). The script is as self-contained as possible - I used pacman to automatically install missing packages on load and data is downloaded from online sources (including our repo for the HiC contact matrix).
@jhcreed The script does need some attention both to make the variable names more descriptive and to add comments and notes that would be relevant to an end user.