Add Item IDs to the TagExpParser #570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should effectively treat item tags and ids in the same expression, the only problem I've been able to find with this so far is it will essentially filter the entire name so it no longer would require the name in the beginning. For example, 'c:storage_block*' would also allow any tags such as 'c:storage_blocks/' this could create problems with items with similar IDs. I've tested this in the GametestWorld and it seems to filter IDs now as well. So, as I've had a problem with before, items can be wildcarded, so 'allthecompressed:' is now a valid expression allowing all blocks from the mod to export, but 'allthecompressed:raw*' will now allow all blocks from the mod to be exported. Because of this, the list can be very generalized so 'raw' will move anything with any ID or tag containing the word raw.