Skip to content

Conversation

@Dawid212
Copy link
Contributor

This pr adds enable_flow_logs field to subnetwork resource

compute: add `enable_flow_logs` field to `google_compute_subnetwork` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 28, 2025
@github-actions github-actions bot requested a review from BBBmau December 28, 2025 22:01
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 108 insertions(+))
google-beta provider: Diff ( 4 files changed, 108 insertions(+))
terraform-google-conversion: Diff ( 4 files changed, 35 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1318
Passed tests: 1231
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccComputeSubnetwork_subnetworkLoggingConfigExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccComputeSubnetwork_subnetworkLoggingConfigExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestAccComputeFutureReservation_sharedFutureReservationExample is a flaky test and can be ignored.

TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update is consistently passing in TC, we'll rerun this once the comment is addressed.

default to disabled. This field isn't supported if the subnet purpose field is set
to REGIONAL_MANAGED_PROXY.
default_from_api: true
send_empty_value: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we have send_empty_value: true simultaneously with default_from_api: true it only sends an empty value if it's explicitly set in config. We may want to remove this since when unset it would continue to use the default_from_api which looks to be false as it's a boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants