-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add subnetwork enable_flow_logs field #16034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1318 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
BBBmau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestAccComputeFutureReservation_sharedFutureReservationExample is a flaky test and can be ignored.
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update is consistently passing in TC, we'll rerun this once the comment is addressed.
| default to disabled. This field isn't supported if the subnet purpose field is set | ||
| to REGIONAL_MANAGED_PROXY. | ||
| default_from_api: true | ||
| send_empty_value: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we have send_empty_value: true simultaneously with default_from_api: true it only sends an empty value if it's explicitly set in config. We may want to remove this since when unset it would continue to use the default_from_api which looks to be false as it's a boolean.
This pr adds enable_flow_logs field to subnetwork resource