add enable field to packetmirroring resource #16036
Conversation
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
c2thorn
left a comment
c2thorn
left a comment
There was a problem hiding this comment.
we should test updating the value to false and then true again via an update test: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test
| description: | | ||
| Indicates whether or not this packet mirroring takes effect. If set to FALSE, this packet mirroring | ||
| policy will not be enforced on the network. The default is TRUE. | ||
| default_value: "TRUE" |
There was a problem hiding this comment.
for a top-level field like this, I'd prefer to use default_from_api: true instead of default_value to avoid suddenly enabling potentially dormant existing resources
3 participants
this pr adds enable field to packet mirroring resource