Sync main dec 30 feature branch resource identity #16049
Conversation
…et for spanner instances (GoogleCloudPlatform#15919)
…5306) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…#15933) Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…latform#15861) Co-authored-by: Marek Lipert <lipertmj@google.com>
…#15930) Signed-off-by: Julia Zou <yueyangz@google.com>
…to prevent Terraform from managing the settings.0.backup_configuration block when an instance is managed by GCBDR. (GoogleCloudPlatform#15710) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…tform#14956) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…onnect_resourceManagerTags (GoogleCloudPlatform#16009)
…ntryBigqueryTableExample (GoogleCloudPlatform#16026)
modular-magician
added
the
awaiting-approval
…-FEATURE-BRANCH-resource-identity
modular-magician
added
service/terraform
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_instance" "primary" {
observability_config {
track_wait_event_types = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_compute_region_commitment" "primary" {
type = # value needed
}
Resource: resource "google_datastream_stream" "primary" {
rule_sets {
customization_rules {
bigquery_clustering {
columns = # value needed
}
bigquery_partitioning {
ingestion_time_partition {
partitioning_time_granularity = # value needed
}
integer_range_partition {
column = # value needed
end = # value needed
interval = # value needed
start = # value needed
}
require_partition_filter = # value needed
time_unit_partition {
column = # value needed
partitioning_time_granularity = # value needed
}
}
}
object_filter {
source_object_identifier {
mongodb_identifier {
collection = # value needed
database = # value needed
}
mysql_identifier {
database = # value needed
table = # value needed
}
oracle_identifier {
schema = # value needed
table = # value needed
}
postgresql_identifier {
schema = # value needed
table = # value needed
}
salesforce_identifier {
object_name = # value needed
}
sql_server_identifier {
schema = # value needed
table = # value needed
}
}
}
}
}
Resource: resource "google_netapp_volume" "primary" {
hybrid_replication_parameters {
cluster_location = # value needed
hybrid_replication_type = # value needed
large_volume_constituent_count = # value needed
peer_cluster_name = # value needed
peer_ip_addresses = # value needed
peer_svm_name = # value needed
peer_volume_name = # value needed
}
}
Resource: resource "google_sql_database_instance" "primary" {
replication_cluster {
psa_write_endpoint = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 3999 Click here to see the affected service packages
Action takenFound 135 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
/gcbrun |
modular-magician
added
awaiting-approval
|
@shuyama1 just a heads-up im working on a commit that will resolve the failing test on: TestAccPublicCAExternalAccountKey_publicCaExternalAccountKeyExample it's a missing resource identity on create due to it having a Edit: PR that prevents identity support on resources that have |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_instance" "primary" {
observability_config {
track_wait_event_types = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_compute_region_commitment" "primary" {
type = # value needed
}
Resource: resource "google_datastream_stream" "primary" {
rule_sets {
customization_rules {
bigquery_clustering {
columns = # value needed
}
bigquery_partitioning {
ingestion_time_partition {
partitioning_time_granularity = # value needed
}
integer_range_partition {
column = # value needed
end = # value needed
interval = # value needed
start = # value needed
}
require_partition_filter = # value needed
time_unit_partition {
column = # value needed
partitioning_time_granularity = # value needed
}
}
}
object_filter {
source_object_identifier {
mongodb_identifier {
collection = # value needed
database = # value needed
}
mysql_identifier {
database = # value needed
table = # value needed
}
oracle_identifier {
schema = # value needed
table = # value needed
}
postgresql_identifier {
schema = # value needed
table = # value needed
}
salesforce_identifier {
object_name = # value needed
}
sql_server_identifier {
schema = # value needed
table = # value needed
}
}
}
}
}
Resource: resource "google_netapp_volume" "primary" {
hybrid_replication_parameters {
cluster_location = # value needed
hybrid_replication_type = # value needed
large_volume_constituent_count = # value needed
peer_cluster_name = # value needed
peer_ip_addresses = # value needed
peer_svm_name = # value needed
peer_volume_name = # value needed
}
}
Resource: resource "google_sql_database_instance" "primary" {
replication_cluster {
psa_write_endpoint = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
|
Thanks for the heads-up. I've triggered a rerun, and hopefully the sql tests will pass this time, as they failed due to transient issues. I'm not sure about the BackupDR failures since they're stable in nightly. Let's see if the rerun clears them up. |
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 3954 Click here to see the affected service packages
Action takenFound 49 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
20 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.