-
Notifications
You must be signed in to change notification settings - Fork 6.7k
chore(deps): update dependency pyspark to v3.5.7 #13693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency pyspark to v3.5.7 #13693
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's dependencies by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR, generated by Renovate, updates the pyspark dependency to version 3.5.7. My review focuses on the context of this change. The Pub/Sub Lite Spark connector, for which this dependency is being updated, is deprecated and its tests are disabled. This means the dependency update is not being validated, which poses a maintenance risk. I have added a comment on the requirements.txt file with a suggestion to mitigate this risk.
| @@ -1 +1 @@ | |||
| pyspark[sql]==3.5.5 No newline at end of file | |||
| pyspark[sql]==3.5.7 No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pyspark dependency update is for the Pub/Sub Lite Spark connector. As noted in spark_streaming_test.py, this connector is deprecated and its tests are currently skipped. This means the change in this PR is not being validated by any tests, introducing a risk of breakage, even for a patch update. To mitigate this, I recommend either re-enabling a minimal set of tests to cover this dependency or configuring Renovate to stop updating dependencies for this deprecated component.
This PR contains the following updates:
==3.5.5→==3.5.7Release Notes
apache/spark (pyspark)
v3.5.7Compare Source
v3.5.6Compare Source
Configuration
📅 Schedule: Branch creation - On day 1 of the month, every 3 months ( * * 1 */3 * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.