Application versions by dapomeroy · Pull Request #1362 · GoogleCloudPlatform/ramble

dapomeroy · 2025-12-15T17:57:24Z

This pull request introduces object versions, which allows for 'when' conditions to be set using versions or version ranges. This feature allows Ramble to better support applications as they change and develop over time. Included in this PR is a new unified 'wrf' application that will replace 'wrfv3' and 'wrfv4', which remain in the repo for now.

See the workspace config and application developer guide documentation for more details on how to use versions.

rfbgo · 2026-01-08T20:32:01Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a versioning system for applications and other objects, which is a significant new feature. The implementation correctly uses the packaging library for version handling and consistently applies version string parsing across the codebase. New directives for version management have also been added.

However, I've identified a few critical issues in the new ObjectVersion class, including an incorrect copy method implementation and a potential NameError in the satisfies method. There are also a couple of medium-severity issues related to redundant code and incorrect attribute naming. These issues should be addressed to ensure the stability and correctness of the new versioning feature.

lib/ramble/ramble/definitions/versions.py

lib/ramble/ramble/experiment_set.py

var/ramble/repos/builtin/base_classes/application-base/base_class.py

lib/ramble/ramble/workspace/workspace.py

var/ramble/repos/builtin/base_classes/object-mixin/base_class.py

dapomeroy · 2026-02-11T05:41:12Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a comprehensive versioning system for applications and other objects within Ramble. It's a significant feature addition that touches many parts of the codebase, from configuration and language directives to command-line tools and testing. The core idea of using the packaging library for version handling is solid. The changes to support versioned object names (e.g., app@1.0) are consistently applied. Overall, this is a great enhancement. I've found a few bugs in the implementation details and a place for potential refactoring for better readability and performance. Please see my detailed comments.

lib/ramble/ramble/language/application_language.py

lib/ramble/ramble/workload.py

lib/ramble/ramble/language/shared_language.py

douglasjacobsen · 2026-02-12T15:24:56Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a comprehensive versioning system for applications and other objects within Ramble. This is a significant feature that allows for more precise dependency management and configuration. The changes are extensive, touching core logic, the domain-specific language, and numerous application files to adopt this new versioning capability. A new ObjectVersion class, based on the robust packaging.version library, is at the core of this feature, which is a solid design choice. The implementation appears well-thought-out and consistent across the codebase. I have found one bug in the output formatting logic that could lead to incorrect display of versioned strings, for which I've provided a suggestion.

lib/ramble/ramble/cmd/common/info.py

Update apps and modifiers in the builtin repo to use version. Creates a merged wrf application, but leaves wrfv3 and wrfv4 unchanged for now.

douglasjacobsen

Thanks! This is looking good! I have several requests and nits.

douglasjacobsen · 2026-02-13T17:05:08Z

lib/ramble/docs/dev_guides/application_dev_guide.rst

+is used to set a version, and ``when`` conditions can be described using the following syntax:
+
+* ``application_version@<version_number>`` Apply to only a specific version.
+* ``application_version@:<version_number>`` Apply to a range up to the specified version.


Up to an including?

douglasjacobsen · 2026-02-13T17:05:16Z

lib/ramble/docs/dev_guides/application_dev_guide.rst

+
+* ``application_version@<version_number>`` Apply to only a specific version.
+* ``application_version@:<version_number>`` Apply to a range up to the specified version.
+* ``application_version@<version_number>:`` Apply to a range from the specified version.


Including again?

douglasjacobsen · 2026-02-13T17:05:29Z

lib/ramble/docs/dev_guides/application_dev_guide.rst

+* ``application_version@<version_number>`` Apply to only a specific version.
+* ``application_version@:<version_number>`` Apply to a range up to the specified version.
+* ``application_version@<version_number>:`` Apply to a range from the specified version.
+* ``application_version@<start_number>:<end_number>`` Apply to a range of versions.


Specify inclusion if possible.

douglasjacobsen · 2026-02-13T17:09:28Z

lib/ramble/docs/dev_guides/application_dev_guide.rst

+* ``application_version@<version_number>:`` Apply to a range from the specified version.
+* ``application_version@<start_number>:<end_number>`` Apply to a range of versions.
+
+Version numbers must conform to `Python packaging.version`_ format. In some cases, it may be


We should probably talk about this. I think we originally wanted the front-end to support spack syntax and then we would convert it to python_packaging.version internally.

I haven't gotten through the rest of the PR yet, but without utilities to go back and forth, it seems like it could easily make aspects of workspaces confusing for users.

And it feels like we can make this easier internally too.

douglasjacobsen · 2026-02-17T21:03:10Z

lib/ramble/ramble/cmd/common/list.py

    """Print all objects with their latest versions."""
-    objs = [ramble.repository.get(name, object_type=object_type) for name in obj_names]
+    objs = [
+        ramble.repository.get(name.partition("@")[0], object_type=object_type)


nit; It might be nice if the partition calls could be added into the repository class, just so people don't have to remember to call it with partition.

douglasjacobsen · 2026-02-17T21:56:37Z

lib/ramble/ramble/util/format.py

    return results.getvalue()
+
+
+def sort_when(when: str):


nit; This might be better called "when_order", since it doesn't actually sort the when conditions.

douglasjacobsen · 2026-02-17T21:56:50Z

lib/ramble/ramble/util/object_utils.py

    if not search_description:
        return False
-    obj = ramble.repository.get(obj_name, object_type=obj_type)
+    obj = ramble.repository.get(obj_name.partition("@")[0], object_type=obj_type)


nit; Same partition comment.

douglasjacobsen · 2026-02-17T21:57:04Z

lib/ramble/ramble/workspace/workspace.py

        obj_name = obj
    try:
-        obj_inst = ramble.repository.get(obj_name, object_type=obj_type)
+        obj_inst = ramble.repository.get(obj_name.partition("@")[0], object_type=obj_type)


nit; Same partition comment.

douglasjacobsen · 2026-02-17T21:59:28Z

lib/ramble/ramble/experiment_set.py

-
        # Setup the application instance
-        app_inst = ramble.repository.get(final_app_name)
+        app_inst = ramble.repository.get(final_app_name.partition("@")[0])


nit; Same partition comment

douglasjacobsen · 2026-02-17T22:36:48Z

lib/ramble/ramble/schema/config.py


 properties["config"]["enable_workspace_prompt"] = {"type": "boolean", "default": False}

+properties["config"]["enable_strict_versions"] = {"type": "boolean", "default": True}


I don't see it in this PR, but would it be useful to have a CLI flag for this?

dapomeroy force-pushed the application_versions branch from 8fedfa8 to f93f7c3 Compare December 19, 2025 21:38

gemini-code-assist bot reviewed Jan 8, 2026

View reviewed changes

rfbgo previously approved these changes Jan 23, 2026

View reviewed changes

lib/ramble/ramble/workspace/workspace.py Outdated Show resolved Hide resolved

var/ramble/repos/builtin/base_classes/object-mixin/base_class.py Outdated Show resolved Hide resolved

dapomeroy dismissed rfbgo’s stale review via 63ace69 January 23, 2026 19:26

dapomeroy force-pushed the application_versions branch 4 times, most recently from 28c1b32 to 00ccc56 Compare January 26, 2026 17:10

dapomeroy force-pushed the application_versions branch 9 times, most recently from bee07e1 to d06fa73 Compare February 11, 2026 05:01

dapomeroy marked this pull request as ready for review February 11, 2026 05:38

dapomeroy force-pushed the application_versions branch from 1caafbb to 99051f1 Compare February 11, 2026 05:40

gemini-code-assist bot reviewed Feb 11, 2026

View reviewed changes

lib/ramble/ramble/language/application_language.py Show resolved Hide resolved

lib/ramble/ramble/workload.py Outdated Show resolved Hide resolved

lib/ramble/ramble/language/shared_language.py Outdated Show resolved Hide resolved

dapomeroy force-pushed the application_versions branch from 99051f1 to 1e425e6 Compare February 11, 2026 19:55

dapomeroy changed the title ~~Application versions (WIP)~~ Application versions Feb 11, 2026

dapomeroy force-pushed the application_versions branch 5 times, most recently from 4d5f868 to 52668d2 Compare February 12, 2026 05:32

gemini-code-assist bot reviewed Feb 12, 2026

View reviewed changes

lib/ramble/ramble/cmd/common/info.py Outdated Show resolved Hide resolved

dapomeroy added 5 commits February 13, 2026 04:53

Create version class and version variants

431612e

Add version directives and setters

2956ed9

Add mock application and modifier for testing

efdfabd

Add 'when' support to workload_group() directive

94bb988

Update repo to use versions

c379091

Update apps and modifiers in the builtin repo to use version. Creates a merged wrf application, but leaves wrfv3 and wrfv4 unchanged for now.

dapomeroy force-pushed the application_versions branch from a1a3ba8 to 4a7993b Compare February 13, 2026 04:53

Update documentation and info test

a6d1ef5

dapomeroy force-pushed the application_versions branch from 4a7993b to a6d1ef5 Compare February 13, 2026 05:06

dapomeroy requested review from douglasjacobsen and linsword13 February 13, 2026 05:15

douglasjacobsen requested changes Feb 17, 2026

View reviewed changes


		properties["config"]["enable_workspace_prompt"] = {"type": "boolean", "default": False}

		properties["config"]["enable_strict_versions"] = {"type": "boolean", "default": True}

Conversation

dapomeroy commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfbgo commented Jan 8, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dapomeroy commented Feb 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

douglasjacobsen commented Feb 12, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

douglasjacobsen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dapomeroy commented Dec 15, 2025 •

edited

Loading