Salem Ba-rabuod #8
Open
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelhdr
approved these changes
Jan 30, 2026
rafaelhdr
left a comment
rafaelhdr
left a comment
There was a problem hiding this comment.
Great code. Easy to read, and everything is working great. Congrats 👏
|
|
||
| if ( isNaN(year) || (year > 9999) || (year < 1)) { | ||
| console.log('Invalid year!'); | ||
| } else { |
There was a problem hiding this comment.
It is great. I have one suggestion, that was not really necessary, but might make the code more clean.
Here is the explanation of early return: https://medium.com/swlh/return-early-pattern-3d18a41bba8
This is small code, so that is fine. But when the code starts growing, you can return things early, and the code is easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.