Open
Conversation
This is a specific change for InWorldz exports to avoid filtering out LiteRezzer scripts from any objects grid-wide without whitelisting a creator user. Not sure if this belongs in Halcyon itself or is just an IW feature, but it's being used in all export OARs now.
InWorldz-specific changes for OAR exports, although the pattern could be used in general.
Not found due to the fact that all assets are loaded and not filtered until objects are filtered since assets don't have creator metadata.
Contributor
|
I think we'd discussed this out of band way back when... To document my current thoughts on this PR: I'd rather that either the PR be split into the bugfix portion and a PR working toward generalizing the whitelisting code, or that the whitelisting be generalized in this PR. Either way, this PR as it stands introduces technical debt that will have to be cleaned up by someone anyway - and we have enough such debt IMO. |
kf6kjg
requested changes
Apr 21, 2021
Contributor
kf6kjg
left a comment
kf6kjg
left a comment
There was a problem hiding this comment.
See above about either splitting off the bug fix portion or generalizing the whitelisting process.
kf6kjg
force-pushed
the
master
branch
4 times, most recently
from
5855a6f to
3276883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My intention with this fork was for it to be specific to InWorldz but it does provide good examples of how to whitelist objects independent of the normal (owner+creator) concerns for whitelist in
load filtered. I've decided we should probably merge this intomastersince it really the only IW-specific code there is theIsWhitelistedObjectfunction, but this code should be completely harmless and demonstrates where to insert such exception cases in any future filtering.However, if it is felt that this branch should not be merged, then there are two commits with a straight fixes for the master, the bottom two: bac40ba and c62e15b which can either be cherrypicked or I can do another branch which only has those two commits.