Fix formatting for offensive matches in MatchCard & MatchTable#376
Fix formatting for offensive matches in MatchCard & MatchTable#376realist-hll wants to merge 3 commits intoHeLO-System:mainfrom
Conversation
realist-hll
commented
Oct 22, 2022
realist-hll
commented
- Fixes MatchCard WinLoseBanner (some victories defaulted to Defeat)
- Fixes offensive mode formatting in MatchCard, e.g. Warfare, Offensive
- Introduce "Mode" column on Match table, e.g. Warfare, Offensive
- Reintroduce "Result" column on Clan page
|
Someone is attempting to deploy a commit to the helo-system Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }, | ||
| sortable: true, | ||
| }, | ||
| ].filter(Boolean); |
There was a problem hiding this comment.
What's that line supposed to do?
There was a problem hiding this comment.
It filters out the result column if null was returned, i.e. when clanId is undefined, e.g. on the matches page, rather than the clans/[cid] page.
Since the "result" column only makes sense on a clans/[cid] match archive table, but not on the matches/ match archive table.
realist-hll
force-pushed
the
fix/match-formatting
branch
from
480d53e to
8a9b3d0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
