Added an odometry prior callback function#1
Open
bobbyshashin wants to merge 2 commits intoHumhu:masterfrom
Open
Added an odometry prior callback function#1bobbyshashin wants to merge 2 commits intoHumhu:masterfrom
bobbyshashin wants to merge 2 commits intoHumhu:masterfrom
Conversation
Humhu
reviewed
Mar 12, 2018
Owner
Humhu
left a comment
There was a problem hiding this comment.
What's the motivation behind having a different odometry topic for the priors, versus using the existing odometry callback?
Author
|
Actually that is the part where I don't understand the factor graph theory
behind very well. So I should either use the pose, or integrate the
velocity, depends on whether I enable it? (If I have the pose prior, then
velocity is not needed?)
Update:
So my understanding is: I have an odometry source, which is a prior for my state variable, either from integrating velocity or lidar odometry poses. And everytime I see an apriltag, which is the observation. Then the factor graph optimize all the states based on all the priors and observations. Is that correct?
|
Removed duplicated subscriber
b0fcf93 to
7100c36
Compare
Owner
|
Ideally you should use both if they are enabled. You may want to add a flag to enable/disable the velocity factor, as you did for the prior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Humphrey,
Could you please take a look at this? I'm not sure whether it's the correct way to do it.