Add author updated feature to submission#4380
Draft
sandeepsajan0 wants to merge 2 commits intomainfrom
Draft
Conversation
frjo
requested changes
Feb 6, 2025
Member
frjo
left a comment
frjo
left a comment
There was a problem hiding this comment.
Works well but can be simplified I think.
| label=_("Applicants"), | ||
| required=False, | ||
| ) | ||
| author.widget.attrs.update({"data-placeholder": "Select..."}) |
Member
There was a problem hiding this comment.
Can we make this author.widget.attrs.update({"data-placeholder": "Select...", "data-js-choices": ""})?
| allowHTML: true, | ||
| }); | ||
| }); | ||
| </script> |
Member
There was a problem hiding this comment.
With setting data-js-choices above I believe this script snippet is not needed.
|
|
||
| {% url 'funds:submissions:change_author' pk=object.pk as author_update_url %} | ||
| {% include 'funds/includes/dialog_form_base.html' with form=form value=value %} | ||
| </form> |
Member
There was a problem hiding this comment.
The "lead" modal is much simpler, no form in form. Here there seems to be two htmx calls, is that needed?
I see that the partner modal looks like above, I suspect that is overcomplicated as well.
| </dl> | ||
| </div> | ||
|
|
||
| {% url 'funds:submissions:change_author' pk=object.pk as author_update_url %} |
Member
There was a problem hiding this comment.
I do not think this is used anywhere.
frjo
added
Type: Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4192
Staff can update the submission's author. Flow is similar to the Lead update but the button is a bit hidden in more actions.
Test Steps