WIP: Replacing comment assignments with a mentions-like UI#4386
Draft
WIP: Replacing comment assignments with a mentions-like UI#4386
Conversation
Contributor
Author
|
would love to hear any thoughts @frjo @theskumar @sandeepsajan0! |
Member
|
The UI looks neat! Some nit picking around workflow and language: Being "assigned" and that becoming a task seems logical to me. Someone "mentioning" me and I get a task less so. If more than one person is "mentioned" who is responsible for the task? Maybe OTF does not see this being used to hand out actual tasks? Perhaps more of mention people and they getting notified? I think it would be better to have "tasks" be only actual tasks, things you need to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept of replacing the current
Assign Tointerface with something that is potentially a little more intuitive and allows multiple users to be mentioned in the same comment with context.Being that this is more of a PoC there is lots of sloppier code that needs to be fixed, along with edge cases to handle to don't look too hard just yet. I more just wanted to open this for discussion before any more work was done on it. Lots of notes were taken from Github, Signal & this blog post
Staff have mentioned multiple users being assigned to the same comment would be nice and they take lots of meeting notes in comments so being able to contextualize why user(s) got assigned could be beneficial
Next steps if we decide to move forward with this:
comment_formJS logic into alpineMy TasksDemo
Screen.Recording.2025-02-07.at.14.54.35.mov
Test Steps