Added seperate method for CMake check in toolchain#55
Open
maxarfvidssonnilsson wants to merge 1 commit intoItJustWorksTM:masterfrom
Open
Added seperate method for CMake check in toolchain#55maxarfvidssonnilsson wants to merge 1 commit intoItJustWorksTM:masterfrom
maxarfvidssonnilsson wants to merge 1 commit intoItJustWorksTM:masterfrom
Conversation
added method for cmake check fixed bug more testing testing the test testing the tests that havent been tested plz temp print for bug fixing removed printouts. changed default CMake path changed default CMake path again. Changed default CMake path once again and another time... attempted fix for find cmake method fix so that cmake on path can be found
AeroStun
requested changes
Jan 6, 2022
Member
AeroStun
left a comment
AeroStun
left a comment
There was a problem hiding this comment.
You can already fix the obvious portability problem stemming from the the executable extension (.exe is only a thing on Windows & AIX; other platforms just have their CMake executable called plain cmake)
Member
|
That aside, looks like a good stepping stone |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 63.64% 63.58% -0.06%
==========================================
Files 81 81
Lines 2968 2977 +9
==========================================
+ Hits 1889 1893 +4
- Misses 1079 1084 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extra method to Toolchain that checks for CMake.
The "Install cmake on startup" pull-request to smce-gd relies on this to work properly.
Squashed a bunch of commits and removed a bunch of unrelated stuff just before making the pull-request. Is a hassle to test so I didn't bother. Should still work but if it doesn't you know why.