This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Add Open/close/query#19
Open
rubensousa wants to merge 4 commits intoJakeWharton:masterfrom
rubensousa:open-close-query
Open
Add Open/close/query#19rubensousa wants to merge 4 commits intoJakeWharton:masterfrom rubensousa:open-close-query
rubensousa wants to merge 4 commits intoJakeWharton:masterfrom
rubensousa:open-close-query
Conversation
Owner
Pre-dates open sourcing when it was being used for multiple views at once. The assumption can be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open/close methods in the DrawerBehavior class don't require any arguments (parent and child views). I had to switch the SimpleArrayMap to an ArrayMap to allow this, since we couldn't iterate through the delegates.
Is there any special reason for storing multiple BehaviorDelegates though? The DrawerBehavior class is instantiated for each view that sets the behavior programmatically or by XML, so why assume there's multiple views with delegates?