This repository was archived by the owner on Mar 9, 2020. It is now read-only.
Speed up ExcelStyleCollection#630
Open
Kizaemon wants to merge 1 commit intoJanKallman:masterfrom
Kizaemon:patch-1
Open
Speed up ExcelStyleCollection#630Kizaemon wants to merge 1 commit intoJanKallman:masterfrom Kizaemon:patch-1
Kizaemon wants to merge 1 commit intoJanKallman:masterfrom
Kizaemon:patch-1
Conversation
Removed redundant dictionary lookups and redundant key casing. My benchmarks show measurable speed increase. The underlying dictionary is already OrdinalIgnoreCase, so no need to apply key.ToLower(CultureInfo.InvariantCulture) The calls should be to the more efficient TryGetValue, instead of two separate calls to ContainsKey and GetValue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed redundant dictionary lookups and redundant key casing.
My benchmarks show measurable speed increase.
The underlying dictionary is already OrdinalIgnoreCase, so no need to apply key.ToLower(CultureInfo.InvariantCulture)
The calls should be to the more efficient TryGetValue, instead of two separate calls to ContainsKey and GetValue.