Fix some typos in High-level-design.md#14
Open
gStart9 wants to merge 1 commit intoJoinMarket-Org:masterfrom
Open
Fix some typos in High-level-design.md#14gStart9 wants to merge 1 commit intoJoinMarket-Org:masterfrom
gStart9 wants to merge 1 commit intoJoinMarket-Org:masterfrom
Conversation
adlai
suggested changes
Mar 27, 2025
| 3. `Maker` | ||
|
|
||
| `OrderbookWatch` does not participate in the Joinmarket protocol, but is an abstraction to allow observation of the Joinmarket pit. It stores order information in a sqlite3 db object. | ||
| `OrderbookWatch` does not participate in the Joinmarket protocol, but is an abstraction to allow observation of the Joinmarket pit. It stores order information in an sqlite3 db object. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
Is it, though? I was under the impression "Sequel" was a microsoft copyrighted product name and not a pronunciation that generic SQL databases use, but I could be very wrong. Happy to change this one back if that's the case.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.