This repository was archived by the owner on May 13, 2022. It is now read-only.
takers: ignore makers with more than max_offers_allowed offers#712
Open
AlexCato wants to merge 1 commit intoJoinMarket-Org:developfrom
Open
takers: ignore makers with more than max_offers_allowed offers#712AlexCato wants to merge 1 commit intoJoinMarket-Org:developfrom
AlexCato wants to merge 1 commit intoJoinMarket-Org:developfrom
Conversation
…, default 15) offers
Member
|
Looks good to me, utACK - Also, I think 15 is reasonable. I wouldn't object to 5-10 either. But I think I'm more influenced by our low-bandwidth message channel (public IRC), it isn't necessary. Anyway ignore that, bikeshedding :) We could consider a |
Contributor
|
Will the orderbook also ignore these makers with these changes, or do we need more code for that? |
Member
|
@wysenynja do you mean ob-watcher? Yes, the on_order_seen callback is in the OrderbookWatch class, and the filter is applied there. Whether that's good or bad, don't know, but then ob-watcher isn't too huge of a deal really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option is configurable and defaults to 15.
Implemented as discusses in #711 and waxwing/belcher on IRC.
I'll build the overlapping offer checks on top of this soon.