[IDEA] usage of version catalogs, kotlin version update and fix for #86#87
[IDEA] usage of version catalogs, kotlin version update and fix for #86#87jim-hart merged 4 commits intoKSP-KOS:developfrom
Conversation
… + removed unnecessary usage of generics due to compilation error
|
Hey @lord41ph4, Hey @jim-hart, |
|
Hey @valery-labuzhsky, thanks for looking at this! The build failed here though. I trust you if you say it's good to merge, but wanted to check first. |
|
@lord41ph4 could you please fix the build? |
|
Ok, let’s see. From the output I see that the build was running with Java 17. I think it's not the Gradle script itself but the runner configuration. |
|
@valery-labuzhsky I changed the Java Version in the workflow file, this should fix the build. Or do you want me to put the Java version in the Gradle script back to 17? - Would also be an option :D |
|
Thank you @lord41ph4, I think 21 is better :-) Let's wait until it's built. |
|
@valery-labuzhsky can you re-trigger the build for me? I think no job ran because the change was not in the IDEA folder. |
|
Unfortunately not. We need to wait for @jim-hart . |
|
@valery-labuzhsky @lord41ph4 build looks good now; are we good to merge? |
|
Sure. I am done with my changes. :) |
|
Awesome, thanks @lord41ph4 and @valery-labuzhsky! |
|
Thanks for merging @jim-hart and @valery-labuzhsky for reviewing the changes. I am glad to contribute to this awesome tool. |
|
Released! 🎉 |
I initially just wanted to fix the syntax highlighting issue. But somehow the project did not compile, so I took the chance to introduce the version catalogs, update some dependencies and do the fix for #86. (Fixes #86)