FIX: Remove scroll with meta-up/down #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conflicts with macOS's caret movement, which makes "move to start/end" (what ⌘↑/↓ does) turn into what Fn↑/↓ does already, and makes it very easy to lose what you're currently typing into chat, as the history scroll doesn't preserve that.
✅ Deploy Preview for wce ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
KittenApps
force-pushed
the
beta
branch
2 times, most recently
from
c4a004f to
2e3f08a
Compare
KittenApps
force-pushed
the
beta
branch
5 times, most recently
from
04500b6 to
6715c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conflicts with macOS's caret movement, which makes "move to start/end" (what ⌘↑/↓ does) turn into what Fn↑/↓ does already, and makes it very easy to lose what you're currently typing into chat, as the history scroll doesn't preserve that.
That was added in 2076f35 (emphasis because I'm sure FBC didn't do that initially, and that change adds this), which is a while back, but I either not play BC enough or spend too much time in dev, where I disable everything, so I never noticed it.
Possibly could be made into a setting, if keeping that would be preferable, because it's really bothering me and my macOS keyboard-fu.